Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs building using readthedocs.yml version 2 #64

Merged
merged 3 commits into from May 19, 2019

Conversation

@weikang9009
Copy link
Member

commented May 18, 2019

migrate from readthedocs configuration file v1 to v2

docs building is successful on my fork

@weikang9009 weikang9009 requested review from sjsrey and slumnitz May 18, 2019

@slumnitz slumnitz referenced this pull request May 18, 2019
22 of 28 tasks complete

@jGaboardi jGaboardi added this to the JOSS paper milestone May 18, 2019

@slumnitz

This comment has been minimized.

Copy link
Member

commented May 19, 2019

Hi @weikang9009, thank you for changing this and the work you are putting into!
Looks great to me too!

On that note, I noticed plot_local_autocorrelation(), spatial_weights() and some via_choropleth() functionality visualisations do not build. Likely due to another issue.

@slumnitz slumnitz merged commit 2e5dff6 into pysal:master May 19, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 94.406%
Details
@weikang9009

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

@slumnitz I took another look at the readthedocs building process. It seems that geopandas is not properly installed using pip. At first, it complains about descartes (ModuleNotFoundError: No module named 'descartes'). After I explicitly included descartes in requirements_dev.txt, it complains about Missing package rtree``.

Not sure about the best way to proceed since conda install geopandas will use a lot of resources and readthedocs might not allow it .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.