New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add observables to sbml export #370

Merged
merged 2 commits into from Jul 25, 2018

Conversation

Projects
None yet
3 participants
@FFroehlich
Contributor

FFroehlich commented Jul 24, 2018

As SBML does not provide any official support for "observables", I have here implemented the SBML export as AssignmentRule to a parameter.

Fabian Fröhlich
@coveralls

This comment has been minimized.

coveralls commented Jul 24, 2018

Coverage Status

Coverage increased (+0.02%) to 79.266% when pulling 5c17fd7 on FFroehlich:master into cf18b9d on pysb:master.

@alubbock

Hi Fabian, thanks for this. The only thing missing was a test which checks that the observables' trajectories match PySB. I extended the existing tests using libroadrunner to check this (it works) and pushed my changes in an additional commit to your pull request branch. Now I think it's ready to go.

@FFroehlich

This comment has been minimized.

Contributor

FFroehlich commented Jul 24, 2018

great, thanks!

@alubbock alubbock merged commit 4993362 into pysb:master Jul 25, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 79.266%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment