New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StochKit export on Python 3 with lxml installed #375

Merged
merged 2 commits into from Oct 17, 2018

Conversation

Projects
None yet
3 participants
@alubbock
Member

alubbock commented Sep 13, 2018

This previously failed because lxml outputs bytes, which
needs conversion into a UTF-8 str on Python 3.

Thanks to @ortega2247 for the report.

Fix StochKit export on Python 3 with lxml installed
This previously failed because lxml outputted bytes, which
needs conversion into a UTF-8 string on Python 3.
@coveralls

This comment has been minimized.

coveralls commented Sep 13, 2018

Coverage Status

Coverage remained the same at 79.179% when pulling eeb7349 on alubbock:stochkit_lxml into 10f8713 on pysb:master.

@coveralls

This comment has been minimized.

coveralls commented Sep 13, 2018

Coverage Status

Coverage increased (+0.8%) to 79.189% when pulling 7eab4c5 on alubbock:stochkit_lxml into 4993362 on pysb:master.

@alubbock alubbock merged commit b1284a7 into pysb:master Oct 17, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alubbock alubbock deleted the alubbock:stochkit_lxml branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment