New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate init kwargs to ScipyOdeSimulator #381

Merged
merged 2 commits into from Oct 18, 2018

Conversation

Projects
None yet
3 participants
@alubbock
Member

alubbock commented Oct 7, 2018

Previously, unrecognised kwargs would be silently ignored. Now a
ValueError is raised if they are not recognised.

Validate init kwargs to ScipyOdeSimulator
Previously, unrecognised kwargs would be silently ignored. Now a
ValueError is raised if they are not recognised.
@coveralls

This comment has been minimized.

coveralls commented Oct 7, 2018

Coverage Status

Coverage increased (+0.01%) to 79.239% when pulling 2852a48 on alubbock:scipyode_kwargs into ede7427 on pysb:master.

@@ -55,6 +55,10 @@ def test_vode_solver_run(self):
simres = self.sim.run()
assert simres._nsims == 1
@raises(ValueError)
def test_invalid_init_kwarg(self):
ScipyOdeSimulator(self.model, tspan=self.time, spam='eggs')

This comment has been minimized.

@jmuhlich

jmuhlich Oct 17, 2018

Member

👍 spam, egg, spam, spam, bacon and spam!

@alubbock alubbock merged commit 7fb35d4 into pysb:master Oct 18, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alubbock alubbock deleted the alubbock:scipyode_kwargs branch Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment