Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate cupsoda init kwargs and integrator opts #383

Merged
merged 3 commits into from Oct 18, 2018

Conversation

Projects
None yet
3 participants
@alubbock
Copy link
Member

commented Oct 7, 2018

Previously, unrecognised kwargs and integrator options were
silently ignored. Now a ValueError is raised if they are not
recognised.

alubbock added some commits Oct 7, 2018

Validate cupsoda init kwargs and integrator opts
Previously, unrecognised kwargs and integrator options were
silently ignored. Now a ValueError is raised if they are not
recognised.
@coveralls

This comment has been minimized.

Copy link

commented Oct 7, 2018

Coverage Status

Coverage increased (+0.7%) to 79.126% when pulling 6b822ed on alubbock:cupsoda_kwargs into 4993362 on pysb:master.

@coveralls

This comment has been minimized.

Copy link

commented Oct 7, 2018

Coverage Status

Coverage decreased (-0.06%) to 79.188% when pulling 0d95006 on alubbock:cupsoda_kwargs into a75dadd on pysb:master.

@jmuhlich
Copy link
Member

left a comment

These three kwarg-checking PRs got me thinking, we might want to refactor some of the common code across all of these into utility functions.

@@ -80,11 +80,20 @@ def test_run_tyson(self):

def test_verbose(self):
solver = CupSodaSimulator(model, tspan=self.tspan, verbose=True,
vol=1e-5,

This comment has been minimized.

Copy link
@jmuhlich

jmuhlich Oct 17, 2018

Member

Oops, this caught a bug in a test already? :)

@alubbock alubbock merged commit d8ad0ae into pysb:master Oct 18, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alubbock alubbock deleted the alubbock:cupsoda_kwargs branch Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.