Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate cupsoda init kwargs and integrator opts #383

Merged
merged 3 commits into from Oct 18, 2018

Conversation

@alubbock
Copy link
Member

@alubbock alubbock commented Oct 7, 2018

Previously, unrecognised kwargs and integrator options were
silently ignored. Now a ValueError is raised if they are not
recognised.

alubbock added 2 commits Oct 7, 2018
Previously, unrecognised kwargs and integrator options were
silently ignored. Now a ValueError is raised if they are not
recognised.
@coveralls
Copy link

@coveralls coveralls commented Oct 7, 2018

Coverage Status

Coverage increased (+0.7%) to 79.126% when pulling 6b822ed on alubbock:cupsoda_kwargs into 4993362 on pysb:master.

Loading

@coveralls
Copy link

@coveralls coveralls commented Oct 7, 2018

Coverage Status

Coverage decreased (-0.06%) to 79.188% when pulling 0d95006 on alubbock:cupsoda_kwargs into a75dadd on pysb:master.

Loading

Copy link
Member

@jmuhlich jmuhlich left a comment

These three kwarg-checking PRs got me thinking, we might want to refactor some of the common code across all of these into utility functions.

Loading

@@ -80,11 +80,20 @@ def test_run_tyson(self):

def test_verbose(self):
solver = CupSodaSimulator(model, tspan=self.tspan, verbose=True,
vol=1e-5,
Copy link
Member

@jmuhlich jmuhlich Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, this caught a bug in a test already? :)

Loading

@alubbock alubbock merged commit d8ad0ae into pysb:master Oct 18, 2018
1 of 2 checks passed
Loading
@alubbock alubbock deleted the cupsoda_kwargs branch Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants