New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BngSimulator: respect cleanup flag in `__init__` #385

Merged
merged 4 commits into from Oct 19, 2018

Conversation

Projects
None yet
3 participants
@alubbock
Member

alubbock commented Oct 11, 2018

The cleanup flag in BngSimulator's __init__() was being ignored;
only the value specified to run() was used. The __init__()
cleanup flag is now treated as a default, which can be overridden
on a per simulation basis in run() if required.

BngSimulator: respect cleanup flag in __init__
The cleanup flag in BngSimulator's __init__() was being ignored. It is
now treated as a default, which can be overriden on a per simulation
basis in run() if required.
@coveralls

This comment has been minimized.

coveralls commented Oct 11, 2018

Coverage Status

Coverage increased (+0.8%) to 79.189% when pulling 129766f on alubbock:bngsim_cleanup into 4993362 on pysb:master.

@coveralls

This comment has been minimized.

coveralls commented Oct 11, 2018

Coverage Status

Coverage increased (+0.005%) to 79.192% when pulling 7651967 on alubbock:bngsim_cleanup into d8ad0ae on pysb:master.

Show resolved Hide resolved pysb/simulator/bng.py Outdated
Show resolved Hide resolved pysb/simulator/bng.py Outdated

@alubbock alubbock merged commit 5ab7838 into pysb:master Oct 19, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 79.192%
Details

@alubbock alubbock deleted the alubbock:bngsim_cleanup branch Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment