Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix distribution name for libroadrunner #396

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
3 participants
@jmuhlich
Copy link
Member

commented Jan 2, 2019

#367 added roadrunner to tests_require, but the correct distribution name is libroadrunner. There is a roadrunner but it's something else. Travis wouldn't catch this because there's an explicit pip install for it. This PR fixes the distribution name.

@jmuhlich jmuhlich requested a review from alubbock Jan 2, 2019

@coveralls

This comment has been minimized.

Copy link

commented Jan 2, 2019

Coverage Status

Coverage remained the same at 79.17% when pulling f6302b3 on jmuhlich:roadrunner-requirement into 3f65185 on pysb:master.

@alubbock
Copy link
Member

left a comment

Looks good. The Appveyor failure appears to be unrelated (some transient issue their end), so LGTM.

@jmuhlich jmuhlich merged commit 5dd4a7d into pysb:master Jan 7, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 79.17%
Details

@jmuhlich jmuhlich deleted the jmuhlich:roadrunner-requirement branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.