Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cython compiler directives for faster simulations #403

Merged
merged 2 commits into from Feb 5, 2019

Conversation

Projects
None yet
3 participants
@alubbock
Copy link
Member

commented Jan 9, 2019

I created a PR for Cython (cython/cython#2595)
which added compiler directive support for cython.inline(), which
is now present in Cython>=0.92

This PR introduces user-configurable Cython compiler directives
within the ScipyOdeSimulator. By default, these directives disable
bounds, wrap around, "None", and initialized checks. Some initial
benchmarking on asv shows a speed improvement of about 5% on my
laptop (every little helps?)

Cython compiler directives for faster simulations
I created a PR for Cython (cython/cython#2595)
which added compiler directive support for cython.inline(), which
is now present in Cython>=0.92

This PR introduces user-configurable Cython compiler directives
within the ScipyOdeSimulator. By default, these directives disable
bounds, wrap around, "None", and initialized checks. Some initial
benchmarking on asv shows a speed improvement of about 5% on my
laptop (every little helps?)
@coveralls

This comment has been minimized.

Copy link

commented Jan 9, 2019

Coverage Status

Coverage decreased (-0.002%) to 79.067% when pulling a5c2fe2 on alubbock:cython_directives into f3db9b5 on pysb:master.

@coveralls

This comment has been minimized.

Copy link

commented Jan 9, 2019

Coverage Status

Coverage decreased (-0.4%) to 79.17% when pulling 702ee38 on alubbock:cython_directives into b8e036c on pysb:master.

@jmuhlich
Copy link
Member

left a comment

Whoa, that's awesome.

@alubbock alubbock merged commit 2afc709 into pysb:master Feb 5, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 79.067%
Details

@alubbock alubbock deleted the alubbock:cython_directives branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.