Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-alphanumeric characters from cupSODA model path #404

Merged
merged 2 commits into from Feb 5, 2019

Conversation

Projects
None yet
3 participants
@alubbock
Copy link
Member

commented Jan 9, 2019

cupSODA doesn't quote paths, which is problematic when a model
name includes e.g. spaces. The path is now sanitized to replace
non-alphanumeric characters with an underscore.

Fixes: #397

Remove non-alphanumeric characters from cupSODA model path
cupSODA doesn't quote paths, which is problematic when a model
name includes e.g. spaces. The path is now sanitized to replace
non-alphanumeric characters with an underscore.

Fixes: #397
@coveralls

This comment has been minimized.

Copy link

commented Jan 9, 2019

Coverage Status

Coverage decreased (-0.008%) to 79.069% when pulling 6aeaaf0 on alubbock:cupsoda_model_path into b19d85d on pysb:master.

@alubbock alubbock merged commit f3db9b5 into pysb:master Feb 5, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage decreased (-0.008%) to 79.069%
Details

@alubbock alubbock deleted the alubbock:cupsoda_model_path branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.