Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve underdetermined SBML export #420

Merged
merged 5 commits into from Mar 5, 2019

Conversation

Projects
None yet
3 participants
@FFroehlich
Copy link
Contributor

commented Feb 25, 2019

Not specifying any initial conditions for a species is valid SBML but the resulting model is underdetermined and simulation should fail (it actually does not, as many simulators implement a default value of 0.0, which is also the case for libroadrunner which is used in the pysb tests). See sbmlteam/sbml-test-suite#54

FFroehlich added some commits Feb 11, 2019

@coveralls

This comment has been minimized.

Copy link

commented Feb 25, 2019

Coverage Status

Coverage increased (+0.009%) to 78.939% when pulling 9104f58 on FFroehlich:zero_initial_assignment into 967b986 on pysb:master.

@alubbock alubbock merged commit 01b7874 into pysb:master Mar 5, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.009%) to 78.939%
Details

@FFroehlich FFroehlich deleted the FFroehlich:zero_initial_assignment branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.