Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include StockKit log file in exceptions #429

Merged
merged 3 commits into from Apr 24, 2019

Conversation

Projects
None yet
3 participants
@alubbock
Copy link
Member

commented Apr 3, 2019

I've added a custom Exception class, StochKitSimulatorException.

StochKit often has STDOUT messages that include something like:

Check log file "compile-log.txt" for error messages

The new Exception class parses the log message with a regex,
and attempts to read the log file for inclusion in the error
message. This is helpful since the log file and other temp
files are cleanup up by default.

alubbock added some commits Apr 2, 2019

Include StockKit log file in exceptions
I've added a custom Exception class, StochKitSimulatorException.

StochKit often has STDOUT messages than include something like:

    Check log file "compile-log.txt" for error messages

The new Exception class parses the log message with a regex,
and attempts to read the log file for inclusion in the error
message. This is helpful since the log file and other temp
files are cleanup up by default.
@coveralls

This comment has been minimized.

Copy link

commented Apr 3, 2019

Coverage Status

Coverage decreased (-0.2%) to 77.985% when pulling 98d1cf4 on alubbock:stochkit_logfile into c23608a on pysb:master.

@alubbock alubbock merged commit 66e70a0 into pysb:master Apr 24, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.2%) to 77.985%
Details

@alubbock alubbock deleted the alubbock:stochkit_logfile branch Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.