Fix Simulator #sims calculation for NFsim #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Network free simulators use initials_dict instead of initials, as they don't always have a full list of species available. The Simulator class calculates the number of simulations by checking the number of initials and parameter sets defined. With one parameter set and multiple initials defined, only one simulation was run (with the first set of initials). This PR fixes this issue and adds multiple unit tests for NFsim.
Merged
jmuhlich
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network free simulators use initials_dict instead of initials,
as they don't always have a full list of species available.
The Simulator class calculates the number of simulations by
checking the number of initials and parameter sets defined.
With one parameter set and multiple initials defined, only
one NFsim simulation was run (with the first set of initials).
This PR fixes this issue and adds multiple unit tests for NFsim.