Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Simulator #sims calculation for NFsim #445

Merged
merged 2 commits into from May 10, 2019

Conversation

Projects
None yet
3 participants
@alubbock
Copy link
Member

commented Apr 26, 2019

Network free simulators use initials_dict instead of initials,
as they don't always have a full list of species available.
The Simulator class calculates the number of simulations by
checking the number of initials and parameter sets defined.
With one parameter set and multiple initials defined, only
one NFsim simulation was run (with the first set of initials).

This PR fixes this issue and adds multiple unit tests for NFsim.

Fix Simulator #sims calculation for NFsim
Network free simulators use initials_dict instead of initials,
as they don't always have a full list of species available.
The Simulator class calculates the number of simulations by
checking the number of initials and parameter sets defined.
With one parameter set and multiple initials defined, only
one simulation was run (with the first set of initials).

This PR fixes this issue and adds multiple unit tests for NFsim.

@alubbock alubbock added the bug label Apr 26, 2019

@coveralls

This comment has been minimized.

Copy link

commented Apr 26, 2019

Coverage Status

Coverage increased (+0.1%) to 78.31% when pulling 42c7186 on alubbock:nfsim_fixes into 4c51327 on pysb:master.

@coveralls

This comment has been minimized.

Copy link

commented Apr 26, 2019

Coverage Status

Coverage increased (+0.9%) to 79.262% when pulling 4640070 on alubbock:nfsim_fixes into 26a51a0 on pysb:master.

@alubbock alubbock referenced this pull request Apr 26, 2019

Open

KappaSimulator #447

@alubbock alubbock merged commit ed304ee into pysb:master May 10, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.9%) to 79.262%
Details

@alubbock alubbock deleted the alubbock:nfsim_fixes branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.