Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Model.update_initial_condition_pattern #446

Merged
merged 2 commits into from May 10, 2019

Conversation

Projects
None yet
3 participants
@alubbock
Copy link
Member

commented Apr 26, 2019

It appears this function was non-functional and was not being tested.
This PR rectifies both.

Fix Model.update_initial_condition_pattern
It appears this function was non-functional and was not being tested.
This PR rectifies both.

@alubbock alubbock added the bug label Apr 26, 2019

@coveralls

This comment has been minimized.

Copy link

commented Apr 26, 2019

Coverage Status

Coverage increased (+0.9%) to 79.358% when pulling 6cf4e62 on alubbock:fix_update_initial into ed304ee on pysb:master.

@jmuhlich
Copy link
Member

left a comment

Oh man... That code was from an intermediate state of the fixed-initials work, 40ef9de. I renamed the class to Initial but forgot to update this method. Also, I'm not sure why I built a new Initial rather than mutating the old one in-place...

@alubbock alubbock merged commit 468e6cf into pysb:master May 10, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.9%) to 79.358%
Details

@alubbock alubbock deleted the alubbock:fix_update_initial branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.