Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ModelNotDefinedError #452

Merged
merged 2 commits into from Jul 12, 2019

Conversation

@alubbock
Copy link
Member

alubbock commented Jul 11, 2019

This error should be raised when self exporter is used and a model
component is declared before Model(). It's broken on
Python 3.7 without this PR:

TypeError: descriptor '__init__' requires a 'ValueError' object but received a 'ModelNotDefinedError'
This error should be raised when self exporter is used and a model
component is declared before Model().
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 11, 2019

Coverage Status

Coverage increased (+0.04%) to 78.619% when pulling 649df3d on alubbock:fix_modelnotdef into 4f9f4a1 on pysb:master.

Copy link
Member

jmuhlich left a comment

Oops, that was mighty sloppy of me. What was I thinking?! Thanks for the fix.

@jmuhlich

This comment has been minimized.

Copy link
Member

jmuhlich commented Jul 12, 2019

By the way it breaks on 2.7 as well.

@alubbock alubbock merged commit 39fdaa4 into pysb:master Jul 12, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alubbock alubbock deleted the alubbock:fix_modelnotdef branch Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.