Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueError if reverse rate specified on irreversible rule #471

Merged
merged 2 commits into from Nov 13, 2019

Conversation

alubbock
Copy link
Member

@alubbock alubbock commented Nov 12, 2019

For example, the following should cause an error, because a reverse
rate has been specified but the rule expression is not reversible:

Rule('r1', None >> A(), kf, kr)

For example, the following should cause an error, because a reverse
rate has been specified but the rule expression is not reversible:

    Rule('r1', None >> A(), kf, kr)
@codecov-io
Copy link

@codecov-io codecov-io commented Nov 12, 2019

Codecov Report

No coverage uploaded for pull request base (master@cf08a76). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #471   +/-   ##
========================================
  Coverage          ?   79.9%           
========================================
  Files             ?      99           
  Lines             ?   10141           
  Branches          ?       0           
========================================
  Hits              ?    8103           
  Misses            ?    2038           
  Partials          ?       0
Impacted Files Coverage Δ
pysb/core.py 88.41% <100%> (ø)
pysb/tests/test_core.py 95.6% <100%> (ø)
pysb/examples/fricker_2010_apoptosis.py 97.8% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf08a76...f052aae. Read the comment docs.

Copy link
Member

@jmuhlich jmuhlich left a comment

Good catch.

@alubbock alubbock merged commit d1afd8b into pysb:master Nov 13, 2019
1 of 2 checks passed
@alubbock alubbock deleted the revrule_validation branch Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants