Skip to content

Backport Sphinx 1.6 support to PyScaffold 2.5 #152

Description

@FlorianWilhelm

Right now PyScaffold 2.5.x can only handle Sphinx up to version 1.5 since there was an API change. PyScaffold 3 was changed accordingly and this change could be also back-ported to PyScaffold 2.5.x.

Activity

  1. added
    help wantedExtra attention is needed and contributors are encouraged to participate
    on Mar 20, 2018
  2. cpaulik commented on Apr 4, 2018

    @cpaulik
    Contributor

    Is that the reason for an error like:

    python setup.py docs
    running build_sphinx
    usage: usage: setup.py [OPTIONS] -o <OUTPUT_PATH> <MODULE_PATH> [EXCLUDE_PATTERN, ...]
    setup.py: error: unrecognized arguments: setup.py
    

    ?

  3. FlorianWilhelm commented on Apr 4, 2018

    @FlorianWilhelm
    MemberAuthor

    @cpaulik Yes, exactly. You can double check by downgrading Sphinx to version 1.5.

  4. cpaulik commented on Apr 4, 2018

    @cpaulik
    Contributor

    It works with sphinx 1.5. If you can point me to the changes that were necessary for Pyscaffold 3 then I will take a look at Pyscaffold 2.5.x. Maybe I can whip up a PR.

  5. FlorianWilhelm commented on Apr 4, 2018

    @FlorianWilhelm
    MemberAuthor
  6. added a commit that references this issue on Apr 11, 2018
    5499547
  7. FlorianWilhelm commented on Apr 12, 2018

    @FlorianWilhelm
    MemberAuthor

    @cpaulik I added some commits to v2.x that updated pbr to version 4.0.2. It seems to work now, could you also check if it works for you?

  8. FlorianWilhelm commented on Apr 14, 2018

    @FlorianWilhelm
    MemberAuthor

    @cpaulik, v2.5.11 was just released which fixes this issue.

  9. cpaulik commented on Apr 18, 2018

    @cpaulik
    Contributor

    Thanks. Works perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedExtra attention is needed and contributors are encouraged to participate

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions