Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change helpers to use pathlib.Path #211

Closed
abravalheri opened this issue Aug 31, 2018 · 3 comments
Closed

Change helpers to use pathlib.Path #211

abravalheri opened this issue Aug 31, 2018 · 3 comments
Assignees
Labels
needs discussion This topic should be discussed further
Milestone

Comments

@abravalheri
Copy link
Collaborator

In the past when introducing the extensions API, one point that was controversial was the usage of either lists of file path parts or strings using the forward slash as separator for helpers.ensure and helpers.reject.

It was suggested that we could use pathlib.Path to simplify the code.

Now that we run on Python 3 and pathlib is part of the standard library we can discuss more about that.

Since it breaks the API, if we go for this approach, we would have to start deprecating it now so we can include it in the next major release.

@abravalheri abravalheri added the needs discussion This topic should be discussed further label Aug 31, 2018
@abravalheri abravalheri modified the milestones: v4.0, v3.2 Aug 31, 2018
@abravalheri
Copy link
Collaborator Author

If we decide to adopt the new behaviour:

v3.2 - Deprecation Notice
v4.0 - Actual change

@FlorianWilhelm
Copy link
Member

@abravalheri Sounds like a great idea. Since it was included in Python 3.4 we should do it as you said. Thanks!

@abravalheri
Copy link
Collaborator Author

Implemented in #215 with deprecation notices.
TODO note added explaining how to drop support for lists/tuples in v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion This topic should be discussed further
Projects
None yet
Development

No branches or pull requests

2 participants