Proposal: Remove logic duplication with templates #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abravalheri
force-pushed
the
dry-templates
branch
from
6bb4226
to
555ae09
Compare
There is some repeated logic when defining an structure with templates. The original API accepts either strings or None objects as file contents, but most of the time we pass either functions or str.Templates, which leads to code duplication for the majority of the templates. This change intends to remove all the duplicated logic by allowing str.Templates and callable to be passed directly as file contents, alongside str and None (backwards compatible).
abravalheri
force-pushed
the
dry-templates
branch
from
555ae09
to
72bc387
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up on top of #294 (although it can be reworked to not depend on it). So from reviewing purposes, it might be worthy to check just the latest commit, since the previous ones are included in #294.
There is some repeated logic when defining an structure with templates. The original API accepts either strings or
Noneobjects as file contents, but most of the time we pass either functions orstring.Templateobjects, which leads to code duplication for the majority of the templates.This change intends to remove all the duplicated logic by allowing
string.Templateand callable objects to be passed directly as file contents, alongsidestrandNone(backwards compatible).