Specify virtualenv as extra dependency for build in tox.ini - #417
Merged
Conversation
`build` seems to rely by default in the stdlib's implementation of `venv` and unfortunately for a specific combination of Windows + conda env + virtualenv (as used by tox), that might be problematic as identified in pyscaffold/pyscaffoldext-markdown#10. According to the discussion in pypa/build#253, specifying `virtualenv` as an extra dependency of `build` seems to be a good workaround. Moreover I would expect some kind speed improvements (virtualenv is reported to be faster than venv).
abravalheri
marked this pull request as ready for review
March 9, 2021 17:00
abravalheri
marked this pull request as draft
March 9, 2021 17:01
Collaborator
Author
|
This approach is now documented in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
buildseems to rely by default in the stdlib's implementation ofvenvand unfortunately for a specific combination of Windows + conda env + virtualenv (as used by tox), that might be problematic as identified in pyscaffold/pyscaffoldext-markdown#10.Approach
According to the discussion in pypa/build#253, specifying
virtualenvas an extra dependency ofbuildseems to be a good workaround. Moreover I would expect some kind speed improvements (virtualenv is reported to be faster than venv).