Note that templates and the generated boilerplate code is 0BSD-licensed #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianWilhelm
added
the
documentation
abravalheri
reviewed
Jun 19, 2021
abravalheri
reviewed
Jun 19, 2021
abravalheri
approved these changes
Jun 19, 2021
Collaborator
abravalheri
left a comment
abravalheri
left a comment
There was a problem hiding this comment.
Looks very good to me, thank you very much.
I added a few comments about the templates/__init__.py file itself.
abravalheri
reviewed
Jun 19, 2021
Co-authored-by: Anderson Bravalheri <andersonbravalheri@gmail.com>
Co-authored-by: Anderson Bravalheri <andersonbravalheri@gmail.com>
Co-authored-by: Anderson Bravalheri <andersonbravalheri@gmail.com>
Member
Author
|
Thanks @abravalheri for your remarks, I merged them all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This addresses the points as discussed under conversation #459.