Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 483 #491

Merged
merged 3 commits into from Sep 8, 2021
Merged

Issue 483 #491

merged 3 commits into from Sep 8, 2021

Conversation

abravalheri
Copy link
Collaborator

@abravalheri abravalheri commented Sep 6, 2021

This PR should fix #483. As described in the issue the solution proposed is to use isolated_build also for docs tasks with tox.

It seems that recent versions of tox just accept the isolated_build option as a global config and not per-environment, which is consistent with their most updated docs.

@coveralls
Copy link

coveralls commented Sep 6, 2021

Pull Request Test Coverage Report for Build 5735333649186816

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 97.187%

Files with Coverage Reduction New Missed Lines %
src/pyscaffold/update.py 1 94.83%
Totals Coverage Status
Change from base Build 6402458940342272: -0.09%
Covered Lines: 1629
Relevant Lines: 1662

💛 - Coveralls

@FlorianWilhelm
Copy link
Member

Cool! Thanks, @abravalheri

@FlorianWilhelm FlorianWilhelm merged commit 352f1dc into master Sep 8, 2021
@FlorianWilhelm FlorianWilhelm deleted the issue-483 branch September 8, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent versionning from git tags
3 participants