Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark counter in skeleton explicitly as unused #495

Merged
merged 1 commit into from Sep 11, 2021

Conversation

abravalheri
Copy link
Collaborator

Some IDEs might complain that the i variable in the for loop of skeleton.py is not used. In general, linters accept unused vars when they are explicitly marked with a _ prefix.

This is also the case of flake8-bugbear:

B007: Loop control variable not used within the loop body.
If this is intended, start the name with an underscore.

Some IDEs might complain that the `i` variable in the for loop of
`skeleton.py` is not used. In general, linters accept unused vars when
they are explicitly marked with a `_` prefix.

This is also the case of
[`flake8-bugbear`](https://pypi.org/project/flake8-bugbear/):

> B007: Loop control variable not used within the loop body.
> If this is intended, start the name with an underscore.
@abravalheri abravalheri changed the title Mark counter in skeleton explicitly marked as unused Mark counter in skeleton explicitly as unused Sep 10, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5236659156418560

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.187%

Totals Coverage Status
Change from base Build 5050665127903232: 0.0%
Covered Lines: 1629
Relevant Lines: 1662

💛 - Coveralls

@FlorianWilhelm
Copy link
Member

Thanks @abravalheri.

BTW, do you also see in Github in the "Files Changed" tab of a PR a lot of unit test errors even though everyting is green in the "conversation" tab?

@FlorianWilhelm FlorianWilhelm merged commit ba0f72f into master Sep 11, 2021
@abravalheri abravalheri deleted the improve-skeleton branch September 11, 2021 11:07
@abravalheri
Copy link
Collaborator Author

Yes, I do 😝

This happens because, since Python 3.10 finally have a release candidate, I decided to start testing PyScaffold with it, so we would be prepared when the time comes.
Cirrus is configured to run the tests and report the errors, but the build status will not be changed by Python 3.10rc1 results.

PyScaffold seems to be ready for 3.10, but it turns out Sphinx isn't (sphinx-doc/sphinx#9505). That is the reason why the integration tests fail on 3.10rc1...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants