Mark counter in skeleton explicitly as unused - #495
Merged
Conversation
Some IDEs might complain that the `i` variable in the for loop of `skeleton.py` is not used. In general, linters accept unused vars when they are explicitly marked with a `_` prefix. This is also the case of [`flake8-bugbear`](https://pypi.org/project/flake8-bugbear/): > B007: Loop control variable not used within the loop body. > If this is intended, start the name with an underscore.
Pull Request Test Coverage Report for Build 5236659156418560
馃挍 - Coveralls |
Member
|
Thanks @abravalheri. BTW, do you also see in Github in the "Files Changed" tab of a PR a lot of unit test errors even though everyting is green in the "conversation" tab? |
Collaborator
Author
|
Yes, I do 馃槤 This happens because, since Python 3.10 finally have a release candidate, I decided to start testing PyScaffold with it, so we would be prepared when the time comes. PyScaffold seems to be ready for 3.10, but it turns out Sphinx isn't (sphinx-doc/sphinx#9505). That is the reason why the integration tests fail on 3.10rc1... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some IDEs might complain that the
ivariable in the for loop ofskeleton.pyis not used. In general, linters accept unused vars when they are explicitly marked with a_prefix.This is also the case of
flake8-bugbear: