Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure *--update* includes added extensions in setup.cfg #496

Merged
merged 2 commits into from Sep 13, 2021

Conversation

abravalheri
Copy link
Collaborator

Prior to this change, new extensions added with --update were not being added to the [pyscaffold] section of setup.cfg.

Prior to this change, new extensions added with `--update` were not
being added to the `[pyscaffold]` section of `setup.cfg`.
@abravalheri abravalheri changed the title Ensure update list added extensions in setup.cfg Ensure *--update* includes added extensions in setup.cfg Sep 12, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5084425416343552

  • 12 of 12 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 97.285%

Totals Coverage Status
Change from base Build 5013985301889024: 0.1%
Covered Lines: 1634
Relevant Lines: 1666

💛 - Coveralls

@abravalheri abravalheri marked this pull request as ready for review September 12, 2021 16:01
@FlorianWilhelm
Copy link
Member

Oh nice! So that's a long-standing bug fixed then? Cool.

@FlorianWilhelm FlorianWilhelm merged commit 9061e3d into master Sep 13, 2021
@FlorianWilhelm FlorianWilhelm deleted the fix-updates branch September 13, 2021 13:06
@abravalheri
Copy link
Collaborator Author

Thanks @FlorianWilhelm!
Yeah, it is one of those things that I have noticed briefly on the past, but never really paid attention to check if it was actually a bug or just something I was missing...
But working on PyScaffold this weekend I had the chance to investigate it better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants