Prevent accidental creation of nested projects#545
Merged
FlorianWilhelm merged 4 commits intomasterfrom Dec 1, 2021
Merged
Conversation
Collaborator
Author
|
@FlorianWilhelm, is this more or less what you had in mind? |
Pull Request Test Coverage Report for Build 6720378509721600
💛 - Coveralls |
Member
|
Wow! You are so fast 🚀 Looks really good :-) BTW, I noticed yesterday again how fast the unit tests are. Thanks again for having sped them up so much ⚡ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR attempts to prevent users from accidentally creating nested projects, which may result in problems with
setuptools-scm, as described in #544.Approach
The
pyscaffold.actions.verify_project_dirwas modified to also look for nested repositories and raise an error when relevant.If the
--forceoption is given, PyScaffold will understand that the users know what they are doing and create the project without complaining.