Add colorama as a conditional dependency for Windows - #624
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 6705013379563520
馃挍 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
As discussed in #609 (comment), when we transitioned from v3 to v4 (and were finally allowed to have dependencies), we forgot to add a conditional dependency on
coloramafor windows. (And by "we", I mean that it was definitely me that forgot 馃槄...)coloramais currently being checked on ourtermuicode.Approach
coloramaas a conditional dependency for windows(obs
win32is just the name of the architecture, it does not mean that Python runs on 32 bits. Currently there is nowin64, and that would imply in a change in architecture).