Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colorama as a conditional dependency for Windows #624

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

abravalheri
Copy link
Collaborator

@abravalheri abravalheri commented Mar 10, 2022

Purpose

As discussed in #609 (comment), when we transitioned from v3 to v4 (and were finally allowed to have dependencies), we forgot to add a conditional dependency on colorama for windows. (And by "we", I mean that it was definitely me that forgot 馃槄...)

colorama is currently being checked on our termui code.

Approach

  • Add colorama as a conditional dependency for windows
    (obs win32 is just the name of the architecture, it does not mean that Python runs on 32 bits. Currently there is no win64, and that would imply in a change in architecture).

@coveralls
Copy link

coveralls commented Mar 10, 2022

Pull Request Test Coverage Report for Build 6705013379563520

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.459%

Totals Coverage Status
Change from base Build 5267766528704512: 0.0%
Covered Lines: 1710
Relevant Lines: 1744

馃挍 - Coveralls

@abravalheri abravalheri merged commit e2699fc into master Mar 14, 2022
@abravalheri abravalheri deleted the add-colorama branch March 14, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants