Add BAUDRATE_LITERAL flag, for the case of *BSDs where arbitrary baud… #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rates are generally accepted
zsquareplusc
added a commit
that referenced
this pull request
Oct 9, 2016
|
Thanks, but I think there is a solution without adding a new concept ( |
|
Ah, great! Thank you. =) Definitely cleaner. |
n-eq
pushed a commit
to n-eq/pyserial
that referenced
this pull request
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… rates are generally accepted
This is at the very least true for NetBSD, FreeBSD, and OpenBSD and likely covers any other *BSD you may come across, so we just do a catch-all (with explicit for these three cases) and can sort things out later if the fail or are reported.
This is implemented as a fallback alternative to the BAUDRATE_CONSTANTS because it does not need anything special for setting -- just set ispeed/ospeed to the baudrate and go about your business. Will it fail later? Possibly, but that's fairly rare.
This was tested on FreeBSD -CURRENT, but I've been doing this in non-Python land for a bit (still using termios) with Arduino-related stuff. =)