Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.py: Refactoring #198

Closed
marcogario opened this issue Oct 20, 2015 · 3 comments
Closed

install.py: Refactoring #198

marcogario opened this issue Oct 20, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@marcogario
Copy link
Contributor

@marcogario marcogario commented Oct 20, 2015

install.py needs to be refactored, because it is not manageable, if we want to extend to more platforms.

In particular, we should have a main class: SolverInstaller that deals with the main flow of installation:

  • Download
  • Unpack
  • (Optionally) Compile
  • Create PYTHONPATH

Each Solver Installer would be a subclass of the above, in order to provide specific info like:

  • Where to download from (taking into account platform etc)
  • How to compile
  • How to create the PYTHONPATH

Additionally, it would be nice if the download function was a bit smarter, and it attempted first to use the mirror and then connect to the original URL in case of failure.

@marcogario
Copy link
Contributor Author

@marcogario marcogario commented Oct 20, 2015

Additionally, install.py should provide a way to obtain the necessary pythonpath information, so that we can do:

$ ./install.py --env --z3
export PYTHONPATH=$PYTHONPATH:/..../

$ `./install.py --env --z3`
@marcogario marcogario added enhancement and removed question labels Oct 21, 2015
@marcogario
Copy link
Contributor Author

@marcogario marcogario commented Oct 21, 2015

The current version of install.py does not handle errors in the commands properly. E.g., it is quite common that the compilation failed but install.py thinks everything is ok. The new version should handle this properly.

@marcogario marcogario added this to the 0.4.3 milestone Oct 22, 2015
mikand added a commit that referenced this issue Oct 25, 2015
… Z3 have been ported
mikand added a commit that referenced this issue Oct 30, 2015
mikand added a commit that referenced this issue Nov 6, 2015
… Z3 have been ported
mikand added a commit that referenced this issue Nov 7, 2015
Each solver has now a dedicated class for installation and all the bindings get copied in a specific folder.
@mikand
Copy link
Contributor

@mikand mikand commented Nov 7, 2015

PR #209

@mikand mikand closed this Nov 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.