install.py: Refactoring #198

Closed
marcogario opened this Issue Oct 20, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@marcogario
Contributor

marcogario commented Oct 20, 2015

install.py needs to be refactored, because it is not manageable, if we want to extend to more platforms.

In particular, we should have a main class: SolverInstaller that deals with the main flow of installation:

  • Download
  • Unpack
  • (Optionally) Compile
  • Create PYTHONPATH

Each Solver Installer would be a subclass of the above, in order to provide specific info like:

  • Where to download from (taking into account platform etc)
  • How to compile
  • How to create the PYTHONPATH

Additionally, it would be nice if the download function was a bit smarter, and it attempted first to use the mirror and then connect to the original URL in case of failure.

@marcogario

This comment has been minimized.

Show comment
Hide comment
@marcogario

marcogario Oct 20, 2015

Contributor

Additionally, install.py should provide a way to obtain the necessary pythonpath information, so that we can do:

$ ./install.py --env --z3
export PYTHONPATH=$PYTHONPATH:/..../

$ `./install.py --env --z3`
Contributor

marcogario commented Oct 20, 2015

Additionally, install.py should provide a way to obtain the necessary pythonpath information, so that we can do:

$ ./install.py --env --z3
export PYTHONPATH=$PYTHONPATH:/..../

$ `./install.py --env --z3`

@marcogario marcogario added enhancement and removed question labels Oct 21, 2015

@marcogario

This comment has been minimized.

Show comment
Hide comment
@marcogario

marcogario Oct 21, 2015

Contributor

The current version of install.py does not handle errors in the commands properly. E.g., it is quite common that the compilation failed but install.py thinks everything is ok. The new version should handle this properly.

Contributor

marcogario commented Oct 21, 2015

The current version of install.py does not handle errors in the commands properly. E.g., it is quite common that the compilation failed but install.py thinks everything is ok. The new version should handle this properly.

@marcogario marcogario added this to the 0.4.3 milestone Oct 22, 2015

mikand added a commit that referenced this issue Oct 25, 2015

mikand added a commit that referenced this issue Oct 30, 2015

mikand added a commit that referenced this issue Nov 6, 2015

mikand added a commit that referenced this issue Nov 7, 2015

Refactored solver installing architecture following #198.
Each solver has now a dedicated class for installation and all the bindings get copied in a specific folder.
@mikand

This comment has been minimized.

Show comment
Hide comment
@mikand

mikand Nov 7, 2015

Contributor

PR #209

Contributor

mikand commented Nov 7, 2015

PR #209

@mikand mikand closed this Nov 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment