Installers: Simpler version check via subprocess #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikand
reviewed
Aug 14, 2017
| v = yicespy.__dict__['__YICES_VERSION'] | ||
| m = yicespy.__dict__['__YICES_VERSION_MAJOR'] | ||
| p = yicespy.__dict__['__YICES_VERSION_PATCHLEVEL'] | ||
| version = "%d.%d.%d" % (v, m, p) |
There was a problem hiding this comment.
It would be nice to have an error if the module is not among the recognized ones
mikand
requested changes
Aug 14, 2017
pysmt/cmd/installers/base.py
Outdated
| @@ -11,6 +11,8 @@ | |||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
| from __future__ import print_function | |||
pysmt/cmd/installers/btor.py
Outdated
| "archives", "lingeling-*.tar.gz"))[0] | ||
| boolector_archive = glob.glob(os.path.join(self.extract_path, | ||
| "archives", "boolector-*.tar.gz"))[0] | ||
| SolverInstaller.run("tar xf %s" % lingeling_archive, |
There was a problem hiding this comment.
you did so much that you can now use SolverInstaller.untar, and SolverInstaller.move ...
marcogario
force-pushed
the
installer_version_checker
branch
from
e80fbba
to
f0e15a4
Compare
mikand
approved these changes
Aug 18, 2017
nbailluet
pushed a commit
to nbailluet/pysmt
that referenced
this pull request
Mar 14, 2024
Installers: Simpler version check via subprocess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated and simplified from PR #407.
Main changes: