Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upBoolector: Upgrade to 3.0.0 #514
Conversation
This comment has been minimized.
This comment has been minimized.
I would wait to merge this until upstream accepts Boolector/boolector#9 . I wanted to prepare the PR so that we can run all the tests, and maybe start looking into integrating some of the new features. |
marcogario
force-pushed the
upgrade/btor_3.0.0
branch
from
f961009
to
28f227a
Jul 14, 2018
This comment has been minimized.
This comment has been minimized.
aniemetz
commented
Jul 24, 2018
Boolector/boolector#9 is merged in. Thanks for reporting and providing a fix! |
marcogario
self-assigned this
Aug 5, 2018
marcogario
force-pushed the
upgrade/btor_3.0.0
branch
from
9de709e
to
17c243f
Oct 13, 2018
This comment has been minimized.
This comment has been minimized.
The current CI fails because of the following error:
I think this might be due to a mismatch between the system python and the venv python. Edit: Indeed, the configure says:
|
marcogario
added this to the 0.7.6 milestone
Oct 28, 2018
This comment has been minimized.
This comment has been minimized.
@mikand maybe you are more familiar with cmake, and have an idea of how to fix this? It might be the case that we need to fix it upstream, but it is such a niche case, that I would rather work-around it in Travis or provide a patch to the boolector team. |
marcogario
assigned
mikand
Oct 30, 2018
This comment has been minimized.
This comment has been minimized.
This seems to be a known issue. It mostly affects Mac users (due to the common usage of homebrew and other non-system versions of python). For us the easiest solution would be to call the cmake with the correct flags. For Travis only, here is how another project solved it for linux. |
marcogario
referenced this pull request
Nov 5, 2018
Open
CMake PythonLibs: Incorrect detection from within python virtual environment #24
This comment has been minimized.
This comment has been minimized.
@marcogario Are you working on this? If you want I can try to fix the CI somehow... |
This comment has been minimized.
This comment has been minimized.
I reported this to the Boolector team to identify a principled solution. What I was trying (and you can take over) was to modify the cmakecache from within our installer. |
marcogario
force-pushed the
upgrade/btor_3.0.0
branch
3 times, most recently
from
a6328c8
to
260eb2b
Nov 10, 2018
marcogario
force-pushed the
upgrade/btor_3.0.0
branch
from
260eb2b
to
f751968
Nov 24, 2018
marcogario
added some commits
Jul 14, 2018
mikand
force-pushed the
upgrade/btor_3.0.0
branch
from
f751968
to
accad4c
Jan 15, 2019
mikand
added some commits
Jan 15, 2019
This comment has been minimized.
This comment has been minimized.
The PR should be almost OK now, but tests are failing because it seems that CVC4 1.5 wrapper does not work on python 2.7 and swig3. My suggestion is to postpone the merge of this pr after #552 that should solve the issue with CVC4. |
mikand
added some commits
Jan 21, 2019
mikand
unassigned
marcogario
Jan 22, 2019
mikand
assigned
marcogario
and unassigned
mikand
Jan 22, 2019
This comment has been minimized.
This comment has been minimized.
@marcogario This is ready to merge for me, can you have a look and (if ok) go ahead and merge? |
marcogario commentedJul 14, 2018
Updated installer for boolector 3.0.0. This does not include any new feature.