New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick and dirty fix to make CVC4 installer work again #545

Merged
merged 1 commit into from Dec 4, 2018

Conversation

Projects
None yet
2 participants
@mikand
Contributor

mikand commented Dec 4, 2018

No description provided.

@mikand

This comment has been minimized.

Contributor

mikand commented Dec 4, 2018

@marcogario I understand that you are working to update to the new version of CVC4, but this is a quick fix that should make the tests pass (modulo z3 segfault)

@marcogario

This comment has been minimized.

Contributor

marcogario commented Dec 4, 2018

Lgtm. Thanks for fixing this, the upgrade of cvc4 is taking longer than expected, and I will not manage to look into that for the next few weeks.

If you want to take a look at the branch for upgrading cvc, be my guest! The issue is similar to the one with boolector. Cmake tries to be too smart and there is no way (short of changing the cmake list) for overriding the defaults. In this case, it finds travis ci swig version instead of the one ee install manually.

@marcogario marcogario closed this Dec 4, 2018

@marcogario marcogario reopened this Dec 4, 2018

@marcogario marcogario merged commit 8387853 into master Dec 4, 2018

2 of 5 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@marcogario marcogario deleted the fixing_cvc4_antlr_https branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment