Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload to PypPi (Test) #571

Merged
merged 3 commits into from Apr 13, 2019

Conversation

Projects
None yet
2 participants
@marcogario
Copy link
Contributor

commented Apr 6, 2019

This PR introduces 2 changes:

  1. The azure pipeline is extended to include uploading to PyPI test server after the build succeeds on master
  2. A new way of automatically computing version numbers for dev version.

I would leave this targeting pypi-test for a while, until we are confident that it works as expected.

Notice that the credentials for the pypi test server are stored in azure. See https://docs.microsoft.com/en-us/azure/devops/pipelines/library/service-endpoints?view=azure-devops

@marcogario marcogario requested a review from mikand Apr 6, 2019

@marcogario marcogario added this to the 0.8.1 milestone Apr 6, 2019

@mikand

mikand approved these changes Apr 8, 2019

Copy link
Contributor

left a comment

LGTM

I added few comments, but I think that the PR is fine as it is if the version of python (2 or 3) used for the pypi job is immaterial.

- 'Ubuntu16PyPy3'
- 'OSX10_13'
- 'Win2016'
condition: and(succeeded(), eq(variables['build.sourceBranch'], 'refs/heads/master'))

This comment has been minimized.

Copy link
@mikand

mikand Apr 8, 2019

Contributor

This comment has nothing to do with this PR, but I like your way of expressing the conditions better, so maybe we can change the other conditions in the file as:
and(succeeded(), or(eq(variables['build.sourceBranch'], 'refs/heads/master'), eq(variables['Build.Reason'], 'PullRequest')))

This comment has been minimized.

Copy link
@marcogario

marcogario Apr 13, 2019

Author Contributor

AFAIU the ``succeeded``` part only makes sense if we have a dependsOn. I can change the use of sourceBranch instead of sourceBranchName.

- 'Win2016'
condition: and(succeeded(), eq(variables['build.sourceBranch'], 'refs/heads/master'))
steps:
- script: 'pip install twine wheel'

This comment has been minimized.

Copy link
@mikand

mikand Apr 8, 2019

Contributor

Does the python version on which pip is executed matter? In case you need to use UsePythonVersion@0 task, otherwise ignore this comment.

condition: and(succeeded(), eq(variables['build.sourceBranch'], 'refs/heads/master'))
steps:
- script: 'pip install twine wheel'
- script: './make_distrib.sh; ls dist/'

This comment has been minimized.

Copy link
@mikand

mikand Apr 8, 2019

Contributor

Inside this script we use python, if a specific version is needed we need to use UsePythonVersion@0 and/or the trick used in ci/install_unix.sh

This comment has been minimized.

Copy link
@marcogario

marcogario Apr 13, 2019

Author Contributor

It needs to be the version that matches the pip install of wheel, but otherwise it does not matter. The wheel is a source file and should be cross py2-py3.

marcogario added some commits Apr 13, 2019

CI
CI

@marcogario marcogario self-assigned this Apr 13, 2019

@marcogario marcogario merged commit 749e5e3 into master Apr 13, 2019

1 check passed

clahub All contributors have signed the Contributor License Agreement.
Details

@marcogario marcogario deleted the pypi branch Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.