Skip to content

Commands return correct exit codes. #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 29, 2020
Merged

Commands return correct exit codes. #26

merged 5 commits into from
Sep 29, 2020

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Sep 21, 2020

Changes

  • The creation of the database is moved to the post-parse step in the configuration. Necessary for pytask-environment.
  • Fix exit codes and test them.

@tobiasraabe tobiasraabe added this to the v0.0.7 milestone Sep 21, 2020
@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #26 into main will increase coverage by 1.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   93.87%   95.59%   +1.71%     
==========================================
  Files          31       28       -3     
  Lines        1356     1612     +256     
==========================================
+ Hits         1273     1541     +268     
+ Misses         83       71      -12     
Flag Coverage Δ
#end_to_end 94.04% <ø> (+12.40%) ⬆️
#integration 51.86% <ø> (+1.78%) ⬆️
#unit 60.42% <ø> (-18.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/_pytask/__init__.py 100.00% <ø> (ø)
src/_pytask/build.py 90.74% <ø> (ø)
src/_pytask/clean.py 90.35% <ø> (ø)
src/_pytask/cli.py 100.00% <ø> (ø)
src/_pytask/collect.py 94.06% <ø> (ø)
src/_pytask/config.py 100.00% <ø> (ø)
src/_pytask/dag.py 100.00% <ø> (ø)
src/_pytask/database.py 97.67% <ø> (ø)
src/_pytask/debugging.py 58.82% <ø> (ø)
src/_pytask/enums.py 100.00% <ø> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09efb6a...dd7540c. Read the comment docs.

@tobiasraabe tobiasraabe changed the title Some refactorings. Commands return correct exit codes. Sep 28, 2020
@tobiasraabe tobiasraabe merged commit b5aa10b into main Sep 29, 2020
@tobiasraabe tobiasraabe deleted the refactoring branch September 29, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant