Remove uv as a test dependency. #713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure that the same python interpreter is used to spawn pytask as is running the test we currently rely on `uv` to spawn the instance of python. This relies on us having spawned the test process from `uv` in the first place and requires that `uv` be used by anyone attempting to test the software. This switches the pattern `uv run python` to call (`sys.executable`)[https://docs.python.org/3/library/sys.html#sys.executable] which gives the absolute path of the interpreter being used.
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
==========================================
- Coverage 97.80% 97.19% -0.61%
==========================================
Files 106 114 +8
Lines 8710 9245 +535
==========================================
+ Hits 8519 8986 +467
- Misses 191 259 +68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@erooke, I believe the difference in the two commands does not matter here for me. I am fine with using just the Thank you very much for your contribution! |
tobiasraabe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
To ensure that the same python interpreter is used to spawn pytask as is running the test we currently rely on
uvto spawn the instance of python. This relies on us having spawned the test process fromuvin the first place and requires thatuvbe used by anyone attempting to test the software.This switches the pattern
uv run pythonto callsys.executablewhich gives the absolute path of the interpreter being used.There are three tests left which rely on
uv, they all calluv run pytaskinstead ofuv run python -m pytask. I am not sure how best to handle these at the moment:pytask/tests/test_hook_module.py
Lines 39 to 47 in 48d0286
pytask/tests/test_hook_module.py
Line 83 in 48d0286
pytask/tests/test_warnings.py
Line 151 in 48d0286
Todo
closes #712