Update hatchling version requirement in pyproject.toml #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added changelog entry for version 2.1.2 with artifact building fix.
nicoddemus
reviewed
Nov 11, 2025
| [build-system] | ||
| requires = [ | ||
| "hatchling", | ||
| "hatchling>=1.26", |
Member
There was a problem hiding this comment.
Is there a way to test that the original issue was fixed in CI?
Perhaps running pip check on the installed environment?
Contributor
Author
There was a problem hiding this comment.
Yes, using twine we can do:
twine check --strict dist/*
With the old hatchling this gived:
twine check --strict dist/*
Checking dist/execnet-2.1.2.dev116+gb6018320f-py3-none-any.whl: ERROR InvalidDistribution: Invalid distribution metadata: license-expression introduced in metadata version 2.4, not 2.3
And does not error with the new one.
But I think twine is not used in this project right now. So we add a dependency and it needs to be added in the release process and I do not know where.
Member
There was a problem hiding this comment.
Yes, using twine we can do:
Thanks, I updated test.yml to use this check, it should be working now.
Contributor
Author
There was a problem hiding this comment.
Thanks, looking good!
nicoddemus
approved these changes
Nov 11, 2025
Member
|
Going ahead and merging because the pypy-3.8 failures are being addressed in #375. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #376