Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test "test_cover_looponfail" fails against pytest-3.9.0+ #247

Closed
stanislavlevin opened this issue Dec 18, 2018 · 0 comments · Fixed by #248
Closed

Test "test_cover_looponfail" fails against pytest-3.9.0+ #247

stanislavlevin opened this issue Dec 18, 2018 · 0 comments · Fixed by #248

Comments

@stanislavlevin
Copy link
Contributor

Pytest 3.9.0 changed API for Testdir.runpytest_subprocess() and Testdir.run().
This resulted in:

========================================== FAILURES ===========================================
____________________________________ test_cover_looponfail ____________________________________
/usr/src/RPM/BUILD/python-module-pytest-cov-2.6.0/tests/test_pytest_cov.py:1041: in test_cover_looponfail
    script) as process:
/usr/lib/python2.7/site-packages/_pytest/pytester.py:914: in runpytest
    return self._runpytest_method(*args, **kwargs)
E   TypeError: <lambda>() got an unexpected keyword argument 'timeout'
=================================== short test summary info ===================================
FAIL tests/test_pytest_cov.py::test_cover_looponfail
stanislavlevin added a commit to stanislavlevin/pytest-cov that referenced this issue Dec 18, 2018
@stanislavlevin
Fix test_cover_looponfail test
53fc383 
Pytest 3.9.0 introduced a timeout for ``Testdir.runpytest_subprocess()``
and ``Testdir.run()``. So API has been changed and now it looks like
``run(self, *cmdargs, **kwargs)``.

Hence to comply the new API it needs to fix a lambda's definition.

Fixes: pytest-dev#247
Signed-off-by: Stanislav Levin <slev@altlinux.org>
stanislavlevin added a commit to stanislavlevin/pytest-cov that referenced this issue Dec 18, 2018
@stanislavlevin
Fix test_cover_looponfail test
e73c79e 
Pytest 3.9.0 introduced a timeout for ``Testdir.runpytest_subprocess()``
and ``Testdir.run()``. So API has been changed and now it looks like
``run(self, *cmdargs, **kwargs)``.

Hence to comply with the new API it needs to fix a lambda's definition.

Fixes: pytest-dev#247
Signed-off-by: Stanislav Levin <slev@altlinux.org>
@stanislavlevin stanislavlevin mentioned this issue Dec 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix test_cover_looponfail test stanislavlevin/pytest-cov
1 participant
@stanislavlevin