New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix definition of `cov` fixture for pytest 3 #125

Merged
merged 1 commit into from Jul 13, 2016

Conversation

Projects
None yet
3 participants
@blueyed
Contributor

blueyed commented Jul 12, 2016

With pytest 3.0 (not released yet) the following warning gets emitted:

WC1 None pytest_funcarg__cov: declaring fixtures using
"pytest_funcarg__" prefix is deprecated and scheduled to be removed in
pytest 4.0. Please remove the prefix and use the @pytest.fixture decorator
instead.

@@ -254,7 +254,8 @@ def pytest_runtest_teardown(self, item):
self.cov = None
def pytest_funcarg__cov(request):
@pytest.fixture
def cov(request):
"""A pytest funcarg that provides access to the underlying coverage

This comment has been minimized.

@The-Compiler

The-Compiler Jul 13, 2016

Member

Might make sense to do funcarg -> fixture here too

This comment has been minimized.

@blueyed

blueyed Jul 13, 2016

Contributor

Thanks, done.

Fix definition of `cov` fixture for pytest 3
With pytest 3.0 (not released yet) the following warning gets emitted:

> WC1 None pytest_funcarg__cov: declaring fixtures using
> "pytest_funcarg__" prefix is deprecated and scheduled to be removed in
> pytest 4.0.  Please remove the prefix and use the @pytest.fixture decorator
> instead.

@blueyed blueyed force-pushed the blueyed:fix-deprecation-with-pytest3 branch from 79532fb to 065911e Jul 13, 2016

@ionelmc

This comment has been minimized.

Member

ionelmc commented Jul 13, 2016

Allright, Thanks!

@ionelmc ionelmc merged commit 6d11931 into pytest-dev:master Jul 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@blueyed blueyed deleted the blueyed:fix-deprecation-with-pytest3 branch Jul 13, 2016

jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Aug 22, 2016

wiz
Updated py-test-cov to 2.3.1.
2.3.1 (2016-08-07)
------------------

* Fixed regression causing spurious errors when xdist was used. See `#124
  <https://github.com/pytest-dev/pytest-cov/issues/124>`_.
* Fixed DeprecationWarning about incorrect `addoption` use. Contributed by Florian Bruhin in `PR#127
  <https://github.com/pytest-dev/pytest-cov/pull/127>`_.
* Fixed deprecated use of funcarg fixture API. Contributed by Daniel Hahler in `PR#125
  <https://github.com/pytest-dev/pytest-cov/pull/125>`_.

2.3.0 (2016-07-05)
------------------

* Add support for specifying output location for html, xml, and annotate report.
  Contributed by Patrick Lannigan in `PR#113 <https://github.com/pytest-dev/pytest-cov/pull/113>`_.
* Fix bug hiding test failure when cov-fail-under failed.
* For coverage >= 4.0, match the default behaviour of `coverage report` and
  error if coverage fails to find the source instead of just printing a warning.
  Contributed by David Szotten in `PR#116 <https://github.com/pytest-dev/pytest-cov/pull/116>`_.
* Fixed bug occurred when bare ``--cov`` parameter was used with xdist.
  Contributed by Michael Elovskikh in `PR#120 <https://github.com/pytest-dev/pytest-cov/pull/120>`_.
* Add support for ``skip_covered`` and added ``--cov-report=term-skip-covered`` command
  line options. Contributed by Saurabh Kumar in `PR#115 <https://github.com/pytest-dev/pytest-cov/pull/115>`_.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment