New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get data_file path from Coverage config in subprocesses. #156

Merged
merged 4 commits into from May 11, 2017

Conversation

Projects
None yet
2 participants
@jezdez
Contributor

jezdez commented Apr 24, 2017

Fix #145.

@@ -40,7 +40,8 @@ def set_env(self):
os.environ['COV_CORE_CONFIG'] = config_file
else:
os.environ['COV_CORE_CONFIG'] = ''
os.environ['COV_CORE_DATAFILE'] = os.path.abspath('.coverage')
data_file = os.path.abspath('.coverage')
os.environ['COV_CORE_DATAFILE'] = getattr(self.config, 'data_file', data_file)

This comment has been minimized.

@ionelmc

ionelmc May 9, 2017

Member

AFAIK this is the pytest config object not the coverage one.

@ionelmc

This comment has been minimized.

Member

ionelmc commented May 9, 2017

Anyway, so I've pushed what I think could work, lets see the test results ...

ionelmc added some commits May 10, 2017

@jezdez

This comment has been minimized.

Contributor

jezdez commented May 11, 2017

@ionelmc \o/

@ionelmc ionelmc merged commit d96161e into pytest-dev:master May 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request May 17, 2017

wiz
Updated py-test-cov to 2.5.1.
2.5.1 (2017-05-11)
------------------

* Fixed xdist breakage (regression in ``2.5.0``).
  Fixes `#157 <https://github.com/pytest-dev/pytest-cov/issues/157>`_.
* Allow setting custom ``data_file`` name in ``.coveragerc``.
  Fixes `#145 <https://github.com/pytest-dev/pytest-cov/issues/145>`_.
  Contributed by Jannis Leidel & Ionel Cristian Mărieș in
  `#156 <https://github.com/pytest-dev/pytest-cov/pull/156>`_.

2.5.0 (2017-05-09)
------------------

* Always show a summary when ``--cov-fail-under`` is used. Contributed by Francis Niu in `PR#141
  <https://github.com/pytest-dev/pytest-cov/pull/141>`_.
* Added ``--cov-branch`` option. Fixes `#85 <https://github.com/pytest-dev/pytest-cov/issues/85>`_.
* Improve exception handling in subprocess setup. Fixes `#144 <https://github.com/pytest-dev/pytest-cov/issues/144>`_.
* Fixed handling when ``--cov`` is used multiple times. Fixes `#151 <https://github.com/pytest-dev/pytest-cov/issues/151>`_.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment