Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why DEBUG is hardcoded to False? #228

Closed
bubenkoff opened this issue Apr 9, 2015 · 7 comments
Closed

why DEBUG is hardcoded to False? #228

bubenkoff opened this issue Apr 9, 2015 · 7 comments

Comments

@bubenkoff
Copy link
Member

@bubenkoff bubenkoff commented Apr 9, 2015

Hi

https://github.com/pytest-dev/pytest-django/blob/master/pytest_django/plugin.py#L239

this looks not too flexible
I tried a lot of things before i found this hardcode - i needed to understand why my liveserver fails, and it returned just standard 500 instead of debug page, and debug is set to True in my test settings
So i think this hardcode should be removed to respect test settings

@blueyed
Copy link
Contributor

@blueyed blueyed commented Apr 9, 2015

IIRC the setup with Django's testrunner is also False, to reflect what would be used in production, but I am not certain.

👍 for a way to configure/override this.

Loading

@bubenkoff
Copy link
Member Author

@bubenkoff bubenkoff commented Apr 10, 2015

ok i'll prepare PR

Loading

@birdsarah
Copy link
Contributor

@birdsarah birdsarah commented Oct 29, 2015

Is this fixed? #231 was reverted. This option would be really useful for me.

Loading

@blueyed
Copy link
Contributor

@blueyed blueyed commented Oct 29, 2015

@birdsarah
Thanks for bringing this up.
You could pickup #231 and adjust it according to the feedback (double negation IIRC) and submit is as a new PR, since @bubenkoff appears to have forgotten about it.

Loading

@bubenkoff
Copy link
Member Author

@bubenkoff bubenkoff commented Oct 31, 2015

@blueyed i didn't forget, but don't have time and honestly motivation ATM :)

Loading

@blueyed
Copy link
Contributor

@blueyed blueyed commented Oct 31, 2015

@bubenkoff
Fair enough and thanks for letting us now. That's what I've thought.. :)
Given your existing contribution it should be easy for somebody else to pick it up from there.

@birdsarah
Do you think you can do that?

Loading

@birdsarah
Copy link
Contributor

@birdsarah birdsarah commented Oct 31, 2015

yes, but i've got other contributions that i'm behind on on other projects, so it has to go to the bottom of the stack.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants