Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: test_invalid_template_variable: use include #506

Merged

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 21, 2017

This shows issue pytest-dev/pytest#580, which
is fixed in pytest 3.2.1.

This shows issue pytest-dev/pytest#580, which
is fixed in pytest 3.2.0.
@blueyed blueyed force-pushed the test_invalid_template_variable-include branch from cf63612 to d243d45 Compare August 21, 2017 12:37
@blueyed
Copy link
Contributor Author

blueyed commented Aug 21, 2017

The real fix is to upgrade pytest (#505).
Not sure if we should have a workaround for older pytest versions? (and if it is easily possible after all)

@codecov-io
Copy link

codecov-io commented Oct 10, 2017

Codecov Report

Merging #506 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #506   +/-   ##
=======================================
  Coverage   85.74%   85.74%           
=======================================
  Files          32       32           
  Lines        1614     1614           
  Branches      140      140           
=======================================
  Hits         1384     1384           
  Misses        177      177           
  Partials       53       53
Flag Coverage Δ
#django110 81.72% <ø> (ø) ⬆️
#django111 83.45% <ø> (ø) ⬆️
#django17 79.61% <ø> (ø) ⬆️
#django18 80.79% <ø> (ø) ⬆️
#django19 79.86% <ø> (ø) ⬆️
#mysql_innodb 78.99% <ø> (ø) ⬆️
#mysql_myisam 78.93% <ø> (ø) ⬆️
#postgres 81.22% <ø> (ø) ⬆️
#py27 83.02% <ø> (ø) ⬆️
#py34 80.91% <ø> (ø) ⬆️
#py35 79.12% <ø> (ø) ⬆️
#py36 80.91% <ø> (ø) ⬆️
#pypy 81.59% <ø> (ø) ⬆️
#pypy3 80.79% <ø> (ø) ⬆️
#pytest3 85.74% <ø> (ø) ⬆️
#sqlite 81.59% <ø> (ø) ⬆️
#sqlite_file 80.29% <ø> (ø) ⬆️
Impacted Files Coverage Δ
tests/test_environment.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 781daae...dda25e4. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Oct 10, 2017

Codecov Report

Merging #506 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #506   +/-   ##
=======================================
  Coverage   85.74%   85.74%           
=======================================
  Files          32       32           
  Lines        1614     1614           
  Branches      140      140           
=======================================
  Hits         1384     1384           
  Misses        177      177           
  Partials       53       53
Flag Coverage Δ
#django110 81.72% <ø> (ø) ⬆️
#django111 83.45% <ø> (ø) ⬆️
#django17 79.61% <ø> (ø) ⬆️
#django18 80.79% <ø> (ø) ⬆️
#django19 79.86% <ø> (ø) ⬆️
#mysql_innodb 78.99% <ø> (ø) ⬆️
#mysql_myisam 78.93% <ø> (ø) ⬆️
#postgres 81.22% <ø> (ø) ⬆️
#py27 83.02% <ø> (ø) ⬆️
#py34 80.91% <ø> (ø) ⬆️
#py35 79.12% <ø> (ø) ⬆️
#py36 80.91% <ø> (ø) ⬆️
#pypy 81.59% <ø> (ø) ⬆️
#pypy3 80.79% <ø> (ø) ⬆️
#pytest3 85.74% <ø> (ø) ⬆️
#sqlite 81.59% <ø> (ø) ⬆️
#sqlite_file 80.29% <ø> (ø) ⬆️
Impacted Files Coverage Δ
tests/test_environment.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 781daae...dda25e4. Read the comment docs.

@blueyed blueyed merged commit 1609780 into pytest-dev:master Oct 22, 2017
@blueyed blueyed deleted the test_invalid_template_variable-include branch October 22, 2017 01:55
timb07 pushed a commit to timb07/pytest-django that referenced this pull request May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants