-
Notifications
You must be signed in to change notification settings - Fork 352
Generate _version.py file with setuptools_scm #758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
=========================================
+ Coverage 98.1% 98.31% +0.2%
=========================================
Files 32 34 +2
Lines 1902 2016 +114
Branches 149 152 +3
=========================================
+ Hits 1866 1982 +116
Misses 23 23
+ Partials 13 11 -2
Continue to review full report at Codecov.
|
|
I'd rather recommend using https://github.com/zsimic/setupmeta/. |
|
Ok nice! I was not aware of the and we can get the version of the project as simple as I didn't feel like it was necessary to put constraints to the version of |
ef283c4 to
220a624
Compare
|
@blueyed ping for awareness! :) |
|
@fermezz I'm not too sure about setupmeta anymore given that setuptools-scm is used already. Also I'll leave this open for now (and can amend/change it to "devcommit" myself of course). What do you think? |
|
Totally fine, @blueyed! I can take on that tomorrow, or the day after :) |
|
@blueyed Ok, so I went ahead and changed the versioning to |
|
@fermezz
|
|
Done as part of #880. |
Solves #757 by generating a
_version.pyfile withsetuptools_scm. I think usingpost-releaseasversion-schemeis good because it lets you know the current version of the project, without doing anything more than splitting a string. Feedback is appreciated!