Try to import "mock" before "unittest.mock" #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have hit a bug in mock that is fixed in the version of mock included with Python 3.5.1 but present in 3.3.5 (fixed indirectly in testing-cabal/mock@eba505cf3e). I can install the fixed "mock" package from PyPI, but because `pytest_mock` only uses `unittest.mock` for Python 3.3+, the fixed package has no effect. Instead of trying to check versions, I take the EAFP approach and just try to import `mock` and fall back to `unittest.mock`. It is possible that an old version of "mock" could be installed with a newer Python, but that seems easier to fix than the reverse.
nicoddemus
added a commit
that referenced
this pull request
Jun 10, 2016
|
Thanks for the PR! 😄 |
This was referenced Dec 13, 2016
This was referenced May 19, 2017
This was referenced Feb 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have hit a bug in mock that is fixed in the version of mock included
with Python 3.5.1 but present in 3.3.5 (fixed indirectly in
testing-cabal/mock@eba505cf3e). I can install the fixed "mock" package from
PyPI, but because
pytest_mockonly usesunittest.mockfor Python3.3+, the fixed package has no effect.
Instead of trying to check versions, I take the EAFP approach and just
try to import
mockand fall back tounittest.mock. It is possiblethat an old version of "mock" could be installed with a newer Python,
but that seems easier to fix than the reverse.