Adding support for PySide2 in pytest-qt. #161
Conversation
2 similar comments
|
Oh, nice! Is there a good way to test this on AppVeyor/Travis? Also, can you please take a look at the failing PySide tests? |
| to fix the situation. | ||
| """ | ||
| if qt_api.pytest_qt_api != 'pyside': | ||
| if qt_api.pytest_qt_api not in ('pyside', 'pyside2'): |
There was a problem hiding this comment.
you could just do .startswith('pyqt') instead I guess?
|
|
||
|
|
||
| fails_on_pyqt = pytest.mark.xfail('qt_api.pytest_qt_api != "pyside"') | ||
| fails_on_pyqt = pytest.mark.xfail('qt_api.pytest_qt_api not in ("pyside", "pyside2")') |
There was a problem hiding this comment.
you could just do .startswith('pyqt') instead I guess?
| if self.pytest_qt_api == 'pyside': | ||
| import PySide | ||
| return VersionTuple('PySide', PySide.__version__, self.QtCore.qVersion(), | ||
| if self.pytest_qt_api in ('pyside', 'pyside2'): |
There was a problem hiding this comment.
.startswith('pyside') like you do elsewhere?
|
Thanks for the preliminary work @fabioz! If the wheels from fredrikaverpil/pyside2-wheels can be accessed using |
|
@fabioz Thanks for your work on this PR! Are you (or someone else) planning to finish this PR in the near future? so that CI tests pass. If not I could help with that... |
|
@rth I don't really have the time to do it (and I'm currently not really on PySide2 -- it was mostly an experiment for me and I'm pretty sure I won't be able to get back to it soon, so, feel free to improve on it). |
|
@rth thanks for the offer, definitely this would be a nice addition to pytest-qt! |
5 participants
Adding preliminary support for PySide2 in pytest-qt.
Note that there's still no official binary for it, so, it wasn't added to appveyor. Unofficial binaries may be gotten from bintray.com/fredrikaverpil/pyside2-wheels/pyside2, built based on https://github.com/fredrikaverpil/pyside2-wheels.