Fix API error message and tests on Python 3.6 #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was this before: INTERNALERROR> RuntimeError: Invalid value for $PYTEST_QT_API: <pytestqt.qt_compat._QtApi object at 0x7f00b76f2198>
1 similar comment
Looks like it doesn't have a 3.6 with system-site-packages
Member
Author
|
Looks like Travis doesn't have Python 3.6 with system-site-packages. Removed it for now. Probably can re-add it when I pick up #165 again. |
Member
|
Thanks Florian! All good to be in the same PR, don't worry. I will review this ASAP, thanks again! 😉 |
Member
|
Thanks @The-Compiler! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error was wrong:
I also fixed some test breakage on Python 3.6 and added it to Travis - let me know if you want a separate PR for that instead 😉