Skip to content

Conversation

@rth
Copy link
Contributor

@rth rth commented Sep 13, 2017

Following discussion in #180 this PR proposes a Travis CI setup using conda. Please let me know if I missed anything.

Edit: with the appveyor.yml addition this fixes #180

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rth thanks a ton, this is great work.

I made a few comments, please take a look.

.travis.yml Outdated
- sudo $PYTHON -m pip install -U pytest tox coveralls
- |
if [[ ${PYTEST_QT_API} == 'pyside' ]]; then
pyqt_package="pyside==1.2.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about creating a PYQT_PACKAGE environment variable in the env section along with the others? There will be a small repetition, but I think that's OK.

.travis.yml Outdated
- sudo $PYTHON -m pip install -U pytest tox coveralls
- |
if [[ ${PYTEST_QT_API} == 'pyside' ]]; then
pyqt_package="pyside==1.2.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use fuzzy versions like pyside=1.*, pyqt=4.* and pyqt=5.*.

@nicoddemus
Copy link
Member

Also please make sure to add yourself as a contributor in the README.

@coveralls
Copy link

coveralls commented Sep 13, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 9388845 on rth:conda-CI into 12be2ab on pytest-dev:master.

@coveralls
Copy link

coveralls commented Sep 14, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 8c2e25a on rth:conda-CI into 12be2ab on pytest-dev:master.

@rth rth changed the title Conda setup for Travis CI Conda setup for CI Sep 14, 2017
@coveralls
Copy link

coveralls commented Sep 14, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 882d808 on rth:conda-CI into 12be2ab on pytest-dev:master.

@coveralls
Copy link

coveralls commented Sep 14, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling ea33aa2 on rth:conda-CI into 12be2ab on pytest-dev:master.

@rth
Copy link
Contributor Author

rth commented Sep 14, 2017

@nicoddemus Thanks a lot for the review! I addressed your comments and added the Appveyor setup (largely inspired by the one in qtpy). Also refactored a bit travis setup to be more consistent. Tests now pass. The only point is that in Travis there is a warning/error at the very end,

Done. Your build exited with 0.
XIO:  fatal IO error 11 (Resource temporarily unavailable) on X server ":99.0"
      after 2266 requests (2266 known processed) with 0 events remaining.

but I guess since tests pass that's not relevant...

@rth
Copy link
Contributor Author

rth commented Sep 14, 2017

Also, there is no linting in Appveyor, but since it's already done in Travis that should, hopefully, be sufficient...

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

I agree that we don't need to also run linting on AppVeyor, that's fine.

I commented a minor detail if you can address it, but if you are out of time we can merge as it is. 👍

appveyor.yml Outdated
CONDA_DEPENDENCIES: "pytest tox coveralls pyside=1.*"
- PYTHON_VERSION: "3.4"
PYTEST_QT_API: "pyqt5"
CONDA_DEPENDENCIES: "pytest tox coveralls pyqt=5.*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not using tox and coveralls here so I guess we can remove them.

@coveralls
Copy link

coveralls commented Sep 14, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 5f2c206 on rth:conda-CI into 12be2ab on pytest-dev:master.

@rth
Copy link
Contributor Author

rth commented Sep 14, 2017

Thanks, you are right - I removed tox and coveralls from the Appveyor setup..

@nicoddemus
Copy link
Member

Awesome, thank you, really appreciate it! 👍

@nicoddemus nicoddemus merged commit aa70124 into pytest-dev:master Sep 14, 2017
@rth rth deleted the conda-CI branch September 14, 2017 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider using conda for CI environement

3 participants