Skip to content

Update modeltester to latest Qt sources #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 18, 2018
Merged

Update modeltester to latest Qt sources #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0db09d6
Update modeltester to latest Qt sources
The-Compiler Sep 13, 2018
82d6f15
Add encoding declaration to modeltest.py
nicoddemus Sep 13, 2018
bce819a
Update docs
The-Compiler Sep 13, 2018
41b83ac
Extract data from QVariant
The-Compiler Sep 15, 2018
c2403a0
Fix handling of string types
The-Compiler Sep 15, 2018
de8702b
Handle the multitude of string types possible with PyQt4 in Python 2.7
nicoddemus Sep 17, 2018
bfbaea3
Use only str and QString (when available) for model tests in Python 2
nicoddemus Sep 17, 2018
8009c54
Bring back unicode to string types in Python 2
nicoddemus Sep 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions docs/modeltester.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,19 +36,10 @@ items and call ``qtmodeltester.check``:
If the tester finds a problem the test will fail with an assert pinpointing
the issue.

The following attribute may influence the outcome of the check depending
on your model implementation:
The source code was ported from `qabstractitemmodeltester.cpp`_ by
`Florian Bruhin`_, many thanks!

* ``data_display_may_return_none`` (default: ``False``): While you can
technically return ``None`` (or an invalid ``QVariant``) from ``data()``
for ``QtCore.Qt.DisplayRole``, this usually is a sign of
a bug in your implementation. Set this variable to ``True`` if this really
is OK in your model.

The source code was ported from `modeltest.cpp`_ by `Florian Bruhin`_, many
thanks!

.. _modeltest.cpp: http://code.qt.io/cgit/qt/qtbase.git/tree/tests/auto/other/modeltest/modeltest.cpp
.. _qabstractitemmodeltester.cpp: http://code.qt.io/cgit/qt/qtbase.git/tree/src/testlib/qabstractitemmodeltester.cpp

.. _Florian Bruhin: https://github.com/The-Compiler

Expand Down
Loading