Drop Python 3.6, test on 3.11 #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-Compiler
commented
Apr 28, 2022
| - qt-lib: pyside6 | ||
| os: macos-latest | ||
| os: ubuntu-20.04 |
There was a problem hiding this comment.
The diff here is a bit confusing.
- Dropped the Python 3.6 macOS exclude (not testing there anymore)
- Kept the existing Python 3.7 macOS exclude
- Added a new Python 3.7 Linux exclude: issue comment
- Added a new Python 3.11 PySide6 exclude (pip refuses to install the wheel)
- ditto for PySide2 on Python 3.11 on Windows
| xfail_py311_pyside2 = pytest.mark.xfail( | ||
| sys.version_info[:2] == (3, 11) and qt_api.pytest_qt_api == "pyside2", | ||
| reason="Fails to OR mask flags", | ||
| ) |
There was a problem hiding this comment.
Not sure if this is a PySide2 or Python 3.11 bug:
>>> int(QtCore.Qt.AlignmentFlag.AlignHorizontal_Mask | QtCore.Qt.AlignmentFlag.AlignVertical_Mask)
TypeError: 'PySide2.QtCore.Qt.AlignmentFlag' object cannot be interpreted as an integer
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
SystemError: <class 'int'> returned a result with an exception set
There was a problem hiding this comment.
This XPASSes for me on openSUSE Python 3.11.3 and PySide2 5.15.10
There was a problem hiding this comment.
@bnavigator Thanks, #497 should help.
nicoddemus
approved these changes
Apr 29, 2022
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jun 26, 2023
https://build.opensuse.org/request/show/1095240 by user mcepl + dimstar_suse Forwarded request #1094952 from bnavigator - Remove xfail_strict from pytest config * pyside2 and py311 XPASS a test, gh#pytest-dev/pytest-qt#419
The-Compiler
added a commit
to The-Compiler/pytest-qt
that referenced
this pull request
Jun 26, 2023
Seems to be fixed somewhere between: - PySide2 5.15.2.1 (latest version on PyPI) - PySide2 5.15.10 (version I have installed via Archlinux) But no idea where exactly, so let's just try it out at import time. See pytest-dev#419 (comment)
The-Compiler
added a commit
to The-Compiler/pytest-qt
that referenced
this pull request
Jun 26, 2023
Seems to be fixed somewhere between: - PySide2 5.15.2.1 (latest version on PyPI) - PySide2 5.15.10 (version I have installed via Archlinux) But no idea where exactly, so let's just try it out at import time. See pytest-dev#419 (comment)
The-Compiler
added a commit
that referenced
this pull request
Jun 26, 2023
Seems to be fixed somewhere between: - PySide2 5.15.2.1 (latest version on PyPI) - PySide2 5.15.10 (version I have installed via Archlinux) But no idea where exactly, so let's just try it out at import time. See #419 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to get the CI green again.