New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip if item.session.config.option.reruns is 0 #47

Merged
merged 1 commit into from Jun 23, 2017

Conversation

Projects
None yet
3 participants
@sublee
Contributor

sublee commented Jun 9, 2017

pytest_runtest_protocol returns True even though we don't mark as "should be rerun". Because the default value of item.session.config.option.reruns is 0 not None. This behavior prevents to run pytest_runtest_protocol in other plugins.

@icemac

This comment has been minimized.

Contributor

icemac commented Jun 16, 2017

Thank you for your PR. In #48 I currently prepare a fix for the PyPy3 failures. Before merging your PR I'd like to get that one fixed.

@icemac

This comment has been minimized.

Contributor

icemac commented Jun 16, 2017

#48 was successful. Could you please rebase your branch to current master?

@sublee sublee force-pushed the what-studio:yield-to-other-plugin branch from e123dba to a8af4e3 Jun 16, 2017

@sublee

This comment has been minimized.

Contributor

sublee commented Jun 16, 2017

Sure. I've done.

@sublee

This comment has been minimized.

Contributor

sublee commented Jun 23, 2017

@icemac Didn't you have a plan to merge it?

@sallner

This comment has been minimized.

Contributor

sallner commented Jun 23, 2017

@sublee Sorry for the delay. I will merge it and craft a release in the afternoon.

@sallner sallner merged commit 7025072 into pytest-dev:master Jun 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sallner

This comment has been minimized.

Contributor

sallner commented Jun 23, 2017

@sublee I released a 2.2 just now to pypi.

@sublee

This comment has been minimized.

Contributor

sublee commented Jun 25, 2017

Thank you for merging and releasing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment