Skip to content
Permalink
Browse files

Add regression tests for __init__.py breakage

  • Loading branch information
asottile committed Nov 15, 2019
1 parent 176c777 commit 08ad8f6eaf4500859c6c2cca8741989f28ea082a
Showing with 24 additions and 0 deletions.
  1. +1 −0 AUTHORS
  2. +1 −0 changelog/6194.bugfix.rst
  3. +1 −0 changelog/6197.bugfix.rst
  4. +21 −0 testing/test_collection.py
@@ -70,6 +70,7 @@ Daniel Hahler
Daniel Nuri
Daniel Wandschneider
Danielle Jenkins
Daniil Galiev
Dave Hunt
David Díaz-Barquero
David Mohr
@@ -0,0 +1 @@
Fix incorrect discovery of non-test ``__init__.py`` files.
@@ -0,0 +1 @@
Revert "Fix fail skipping the first test in package marked as ``skip``".
@@ -1257,3 +1257,24 @@ def test_collector_respects_tbstyle(testdir):
"*= 1 error in *",
]
)


def test_does_not_eagerly_collect_packages(testdir):
testdir.makepyfile("def test(): pass")
pydir = testdir.mkpydir("foopkg")
pydir.join("__init__.py").write("assert False")
result = testdir.runpytest()
assert result.ret == ExitCode.OK


def test_does_not_put_src_on_path(testdir):
# `src` is not on sys.path so it should not be importable
testdir.tmpdir.join("src/nope/__init__.py").ensure()
testdir.makepyfile(
"import pytest\n"
"def test():\n"
" with pytest.raises(ImportError):\n"
" import nope\n"
)
result = testdir.runpytest()
assert result.ret == ExitCode.OK

0 comments on commit 08ad8f6

Please sign in to comment.
You can’t perform that action at this time.