From 15ffe6320498f37a57dd23a45866e5903d61f56c Mon Sep 17 00:00:00 2001
From: Ronny Pfannschmidt <ronny.pfannschmidt@redhat.com>
Date: Sat, 23 Nov 2019 01:08:56 +0100
Subject: [PATCH] update  doc examples **untested**

---
 doc/en/deprecations.rst              | 10 ++++++++++
 doc/en/example/nonpython/conftest.py |  4 ++--
 doc/en/example/py2py3/conftest.py    |  2 +-
 3 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/doc/en/deprecations.rst b/doc/en/deprecations.rst
index 748d3ac65a4..88112b12a98 100644
--- a/doc/en/deprecations.rst
+++ b/doc/en/deprecations.rst
@@ -19,6 +19,16 @@ Below is a complete list of all pytest features which are considered deprecated.
 :class:`_pytest.warning_types.PytestWarning` or subclasses, which can be filtered using
 :ref:`standard warning filters <warnings>`.
 
+
+Node Construction changed to ``Node.from_parent``
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+.. deprecated:: 5.3
+
+The construction of nodes new should use the named constructor ``from_parent``.
+This limitation in api surface intends to enable better/simpler refactoring of the collection tree.
+
+
 ``junit_family`` default value change to "xunit2"
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
diff --git a/doc/en/example/nonpython/conftest.py b/doc/en/example/nonpython/conftest.py
index 93d8285bfa7..d30ab3841dc 100644
--- a/doc/en/example/nonpython/conftest.py
+++ b/doc/en/example/nonpython/conftest.py
@@ -4,7 +4,7 @@
 
 def pytest_collect_file(parent, path):
     if path.ext == ".yaml" and path.basename.startswith("test"):
-        return YamlFile(path, parent)
+        return YamlFile.from_parent(parent, fspath=path)
 
 
 class YamlFile(pytest.File):
@@ -13,7 +13,7 @@ def collect(self):
 
         raw = yaml.safe_load(self.fspath.open())
         for name, spec in sorted(raw.items()):
-            yield YamlItem(name, self, spec)
+            yield YamlItem.from_parent(self, name=name, spec=spec)
 
 
 class YamlItem(pytest.Item):
diff --git a/doc/en/example/py2py3/conftest.py b/doc/en/example/py2py3/conftest.py
index 844510a25a3..0291b37b46b 100644
--- a/doc/en/example/py2py3/conftest.py
+++ b/doc/en/example/py2py3/conftest.py
@@ -13,4 +13,4 @@ def collect(self):
 def pytest_pycollect_makemodule(path, parent):
     bn = path.basename
     if "py3" in bn and not py3 or ("py2" in bn and py3):
-        return DummyCollector(path, parent=parent)
+        return DummyCollector.from_parent(parent, fspath=path)