From 802585cb669a669cb6dd9ac9ed7ec4557fd727fd Mon Sep 17 00:00:00 2001 From: Franck Michea Date: Fri, 3 Nov 2017 22:13:47 +0100 Subject: [PATCH 1/2] Clarify language of proposal for parametrized fixtures This change slightly modifies the language of the proposal document around use of fixture as parameters of pytest.mark.parametrize. When looking for documentation around this, I very quickly scrolled through this document and landed on the last paragraph thinking it was documenting a real function. This change attempts to make it less likely for this to happen. --- doc/en/proposals/parametrize_with_fixtures.rst | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/doc/en/proposals/parametrize_with_fixtures.rst b/doc/en/proposals/parametrize_with_fixtures.rst index 381bc98f126..4cff28dd8f7 100644 --- a/doc/en/proposals/parametrize_with_fixtures.rst +++ b/doc/en/proposals/parametrize_with_fixtures.rst @@ -1,8 +1,13 @@ :orphan: -========================= -Parametrize with fixtures -========================= +=================================== +PROPOSAL: Parametrize with fixtures +=================================== + +.. warning:: + + This document outlines a proposal around using fixtures as input + of parametrized tests or fixtures. Problem ------- @@ -108,8 +113,8 @@ the following values. Alternative approach -------------------- -A new helper function named ``fixture_request`` tells pytest to yield all -parameters of a fixture. +A new helper function named ``fixture_request`` would tell pytest to yield +all parameters marked as a fixture. .. code-block:: python From 22e9b006daac4e4a124184387c15b4bd989758ab Mon Sep 17 00:00:00 2001 From: Franck Michea Date: Fri, 3 Nov 2017 22:24:05 +0100 Subject: [PATCH 2/2] Add fragment per PR's guidelines. --- changelog/2893.doc | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog/2893.doc diff --git a/changelog/2893.doc b/changelog/2893.doc new file mode 100644 index 00000000000..a305f1890f2 --- /dev/null +++ b/changelog/2893.doc @@ -0,0 +1 @@ +Clarify language of proposal for fixtures parameters